fix: extended UDP broadcast to reach physical devices outside the virtual Docker network#143
Open
ChemistryTobias wants to merge 1 commit intoChannelFinder:masterfrom
Open
fix: extended UDP broadcast to reach physical devices outside the virtual Docker network#143ChemistryTobias wants to merge 1 commit intoChannelFinder:masterfrom
ChemistryTobias wants to merge 1 commit intoChannelFinder:masterfrom
Conversation
…tual Docker network
|
anderslindho
requested review from
anderslindho,
jacomago,
simon-ess and
tynanford
jacomago
reviewed
Apr 30, 2026
| restart: true | ||
| healthcheck: | ||
| test: netstat | grep cf | ||
| test: curl -s -f http://localhost:8080/ChannelFinder |
Contributor
There was a problem hiding this comment.
This tests channelfinder is up, not recceiver.
| RECCEIVER_CF_CFUSERNAME: admin | ||
| RECCEIVER_CF_CFPASSWORD: password | ||
| RECCEIVER_CF_BASEURL: http://cf:8080/ChannelFinder | ||
| RECCEIVER_CF_BASEURL: http://localhost:8080/ChannelFinder |
Contributor
There was a problem hiding this comment.
This breaks the integration tests which have "cf" as the hostname for channelfinder.
| - net-1-recc-1 | ||
| - net-2-cf | ||
| network_mode: host | ||
|
|
Contributor
There was a problem hiding this comment.
I'm not sure about this. This will.mean container IOC's won't have access to recceiver here?
As mentioned before this will break the integration tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
I installed the RecCeiver service as follows:
But with the current Docker
compose.ymlimplementation, the UDP broadcast is confined to the virtual Docker network and only find IOCs within it.Fix
If this is not the intended standard behavior of your Docker compose, I want to offer a few minor changes, I used in our setup.
Otherwise, just keep up with your project, really like it ✌️